Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gutter Reference Cycle #257

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Fix Gutter Reference Cycle #257

merged 1 commit into from
Jul 14, 2024

Conversation

thecoolwinter
Copy link
Collaborator

Description

Fixes a strong reference cycle in the gutter view.

Related Issues

CodeEditApp/CodeEdit#1794

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A

@thecoolwinter thecoolwinter mentioned this pull request Jul 14, 2024
Merged
6 tasks
@thecoolwinter thecoolwinter merged commit 4e014f7 into CodeEditApp:main Jul 14, 2024
2 checks passed
@thecoolwinter thecoolwinter deleted the fix/gutter-leak branch July 14, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xWDG 0xWDG 0xWDG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thecoolwinter @0xWDG