Toggle comment for current line via CMD + / #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sophiahooley
changed the title
FastestMolasses
requested changes
Apr 19, 2024
Sources/CodeEditSourceEditor/Controller/TextViewController.swift
Outdated
Show resolved
Hide resolved
Sources/CodeEditSourceEditor/Controller/TextViewController.swift
Outdated
Show resolved
Hide resolved
thecoolwinter
requested changes
Apr 20, 2024
There was a problem hiding this comment.
Awesome work, this is close to being ready with a few small things. I left some comments. Some are small organization things (where to put methods, etc) and a few are bugs (responding to commands when unfocused, commenting lines with whitespace). Looks good so far, thanks for the contribution!
Sources/CodeEditSourceEditor/Controller/TextViewController.swift
Outdated
Show resolved
Hide resolved
Sources/CodeEditSourceEditor/Controller/TextViewController.swift
Outdated
Show resolved
Hide resolved
Sources/CodeEditSourceEditor/Controller/TextViewController.swift
Outdated
Show resolved
Hide resolved
Sources/CodeEditSourceEditor/Controller/TextViewController.swift
Outdated
Show resolved
Hide resolved
Sources/CodeEditSourceEditor/Controller/TextViewController.swift
Outdated
Show resolved
Hide resolved
|
Please fix SwiftLint errors |
FastestMolasses
approved these changes
Apr 22, 2024
|
It looks like we have some failing tests. |
|
Looks like the problem is CELangs didn't get a release, so the required comment properties don't exist for the referenced version. I'll update CELangs and push the change to this repo, then merging from main should fix the problem. |
6 tasks
|
@Sophiahooley if you merge from main it should fix the error the test runner is hitting |
thecoolwinter
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the functionality of ⌘ / for single line comments. It allows you to toggle between commented and uncommented for the line the cursor is currently on when you press ⌘ /.
To do so, I implemented a
keyDownevent recognizer, which listens for when the relevant keys are pressed. If ⌘ / is pressed, it calls a method calledcommandSlashCalled(), which decides which toggle is supposed to happen depending on if the line is already commented or not. It also addresses the situation of special cases of languages like HTML, which need a comment at the beginning and end of the line (essentially arangeComment) to comment a single line.Related Issues
This PR accomplishes part of #38. I talked with some of the project leads (@FastestMolasses) and they said it makes sense to break #38 into a couple different issues (I.e. single-line vs highlighted chunks, etc). Single-line comment toggling is completed as of this PR but commenting highlighted code still needs to be completed.
Checklist
Screenshots