Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GutterView Insets Correctly #240

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Update GutterView Insets Correctly #240

merged 1 commit into from
Mar 9, 2024

Conversation

thecoolwinter
Copy link
Collaborator

Description

  • Refactors a few style functions to correctly update the gutter view's position when the content insets change.
  • Adds the gutter view position to the content insets test case.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A

@thecoolwinter thecoolwinter mentioned this pull request Mar 9, 2024
Merged
17 tasks
@thecoolwinter thecoolwinter requested a review from a team March 9, 2024 03:14
austincondiff
austincondiff approved these changes Mar 9, 2024
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this!

@austincondiff austincondiff merged commit 7360f00 into CodeEditApp:main Mar 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austincondiff austincondiff austincondiff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thecoolwinter @austincondiff