🐞 Text Formation edits not registered with Undo Manager #233
Assignees
Labels
bug
Something isn't working
Comments
6 tasks
thecoolwinter
added a commit
that referenced
this issue
Mar 1, 2024
### Description - Cleans up undo/redo operations when TextFormation is activated, for instance when inserting or deleting a newline. > ~Note: Requires [CodeEditTextView#25](CodeEditApp/CodeEditTextView#25) to be merged.~ Merged! ### Related Issues * closes #233 ### Checklist - [x] I read and understood the [contributing guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md) as well as the [code of conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md) - [x] The issues this PR addresses are related to each other - [x] My changes generate no new warnings - [x] My code builds and runs on my machine - [x] My changes are all related to the related issue above - [x] I documented my code ### Screenshots https://github.com/CodeEditApp/CodeEditSourceEditor/assets/35942988/d842b77d-60b4-4afd-be6c-2fb3d0342c4c
github-project-automation
bot
moved this from 🏃♂️ In Progress
to 🏁 Complete
in CodeEdit Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Edits made by text formation filters are not registered in the undo manager. This causes things like newline completions to be ignored when undoing.
To Reproduce
Make an edit that causes a text formation filter to activate (eg, inserting a tab that should be replaced with spaces) and press command-Z. The edit will not be undone correctly.
Expected Behavior
Edits from TextFormation should be able to be undone.
Version Information
CodeEditSourceEditor: 0.7.0
macOS: 14.3.1
Xcode: 15.2
Additional Context
No response
Screenshots
No response
The text was updated successfully, but these errors were encountered: