Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesigned Acknowledgements Window, small modifications to About Window #996

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Redesigned Acknowledgements Window, small modifications to About Window #996

merged 1 commit into from
Jan 18, 2023

Conversation

Wouter01
Copy link
Member

@Wouter01 Wouter01 commented Jan 18, 2023 •
edited
Loading

Signed-off-by: Wouter01 [email protected]

About Window

  • Added translucency
  • Fixed vertical alignment of app icon
  • Disabled minimize and zoom buttons are now hidden
  • Moved Window Controller to separate file

Acknowledgements Window

  • Added translucency
  • Added Icon
  • Made titlebar transparent & without title
  • Disabled minimize and zoom buttons are now hidden
  • Centered Acknowledgements in view
  • Bigger font
  • Moved Window Controller to separate file

Related Issue

None

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

Before

Scherm­afbeelding 2023-01-18 om 19 58 58

Scherm­afbeelding 2023-01-18 om 19 59 13

After

Scherm­afbeelding 2023-01-18 om 19 59 40

Scherm­afbeelding 2023-01-18 om 20 00 09

Scherm­afbeelding 2023-01-18 om 20 00 39

Scherm­afbeelding 2023-01-18 om 20 00 21

@Wouter01 Wouter01 added the enhancement New feature or request label Jan 18, 2023
@Wouter01 Wouter01 self-assigned this Jan 18, 2023
@Wouter01 Wouter01 enabled auto-merge (squash) January 18, 2023 19:06
@Wouter01 Wouter01 merged commit 4fcfe17 into CodeEditApp:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecoolwinter thecoolwinter thecoolwinter approved these changes

@austincondiff austincondiff austincondiff approved these changes

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

@lukepistrol lukepistrol Awaiting requested review from lukepistrol

Assignees

@Wouter01 Wouter01

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wouter01 @austincondiff @thecoolwinter