allow files with a utType that is neither image nor PDF to be previewed #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utType but are neither images nor PDFs See CodeEditApp#1783
matthijseikelenboom
previously requested changes
Jul 26, 2024
thecoolwinter
previously approved these changes
Jul 27, 2024
|
@bombardier200 this might fix the issue you mentioned you noticed with the latest release. |
austincondiff
approved these changes
Jul 27, 2024
thecoolwinter
approved these changes
Jul 27, 2024
plbstl
added a commit
to plbstl/CodeEdit
that referenced
this pull request
Aug 19, 2024
allow files with a utType that is neither image nor PDF to be previewed (CodeEditApp#1822)
austincondiff
pushed a commit
that referenced
this pull request
Aug 21, 2024
…1820) * add `updateStatusBarInfo` view modifier * fix QuickLook previews in single file window * change `fileURL` type to `NSURL` in `AnyFileView` * fix QuickLook previews in Open Quickly Use `dismantleNSView` in `AnyFileView` to prevent crashes when using Open Quickly. What crashes? 1. When using Open Quickly without the workaround in `AnyFileView`, search for a media file (.png, .gif, .mp4, etc) 2. Press escape to close Open Quickly 3. re-open Open Quickly. The media preview is gone 4. Attempt to navigate upwards or downwards using the arrow buttons 5. A crash occurs (QuickLook is attempting to reuse an already closed preview) * add assertionFailure in `CodeEditWindowController.openQuickly` for when an editorManager or statusBarViewModel is unavailable * make `UpdateStatusBarInfo.fileURL` an optional * remove the need to pass environment objects to `NonTextFileView` This also prevents Open Quickly previews from updating the status bar * rename function parameters in `UpdateStatusBarInfo` view modifier * remove `updateStatusBarInfo` view extension * remove guard in `CodeEditWindowController.openQuickly` editorManager and statusBarViewModel environment objects are not used in Open Quickly anymore * merge #1822 fix into this branch allow files with a utType that is neither image nor PDF to be previewed (#1822)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forgot an extra
elsestatement. Seef9433bd(#1783)Checklist