Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Restore Correct Size #1788

Merged

Conversation

thecoolwinter
Copy link
Collaborator

Description

In #1776 changes were made to the windowing system. Previously, a hacky method to trick SwiftUI into setting the initial frame was used, and was removed. This adds back the functionality w/o any of the jank.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

good.mov

@thecoolwinter thecoolwinter added the UI This is UI related label Jul 2, 2024
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@FastestMolasses FastestMolasses merged commit 373d477 into CodeEditApp:main Jul 2, 2024
2 checks passed
@thecoolwinter thecoolwinter deleted the fix/window-size-restoration branch July 2, 2024 17:54
@austincondiff austincondiff added the enhancement New feature or request label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI This is UI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Window Size Restoration Broken
3 participants