Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates our terminal integration to be a little more clever about injections. Introduces a
ShellIntegration
enum, which contains functions for setting up a pseudo terminal for supported shells.Introduces a method for each shell for injecting our pre/post exec handlers:
zsh
.zsh
injection files into that temp folder..zsh
injection file is an override for zsh's real init files (.zprofile
,.zshenv
,.zshrc
,.zlogin
).zdotdir
env variable and store it, replacing it with our own pointing to the temporary directory..zshX
files, we source the user's real zsh init files exactly how zsh does it..zshrc
, we do our injection code.bash
--init-file
parameter for bash. Creating a new, interactive session using our own init file..bashrc
depending on if the session is a login session.These borrow some MIT-licensed code from VSCode and are documented as such, with permalinks to the source files.
Finally, because we're doing this at runtime we can allow users to opt-out of the injection mechanism in settings.
Related Issues
Checklist
Screenshots
Before (zsh example):
Screen.Recording.2024-06-12.at.4.48.06.PM.mov
After: init files still being sourced, not modifying the user's init files, and terminal titles still working.
Zsh:
Screen.Recording.2024-06-12.at.5.10.11.PM.mov
Bash:
Screen.Recording.2024-06-12.at.5.08.26.PM.mov