Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git branches list order and truncate priority issue #1647

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

phlpsong
Copy link
Contributor

Description

Related Issues

Mentioned in #1644 (comment)

  1. Show the current branch first and others ordered alphabetically in the Branch list
  2. Truncate priority issue where the branch name will be truncated first

As mentioned in #1644 (comment), I have decided not to include the fix for updating the icon color using list selection. The transition appeared less smooth, as evident in the screen recording.

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2024-03-24.at.10.32.02.mov

austincondiff
austincondiff previously approved these changes Mar 24, 2024
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I love your momentum, keep up the good work! 🔥

Copy link
Member

@tom-ludwig tom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're on 🔥!
Thanks for your hard work.

CodeEdit/Features/Git/SourceControlManager.swift Outdated Show resolved Hide resolved
@phlpsong
Copy link
Contributor Author

Screenshot 2024-03-25 at 09 25 21 Screenshot 2024-03-25 at 09 25 30

Made some changes in the branch picker list to align with the navigation repo branch list

@austincondiff austincondiff merged commit f6d82b6 into CodeEditApp:main Mar 25, 2024
2 checks passed
@phlpsong phlpsong deleted the git-repo-list-optimize branch March 25, 2024 15:51
FastestMolasses pushed a commit to Angelk90/CodeEdit that referenced this pull request Apr 11, 2024
* fix: branches list order issue and truncate priority of name

* Update SourceControlManager.swift

Co-authored-by: Tom Ludwig <[email protected]>

* fix: optimize branch picker list issue and use lowercase to sort

---------

Co-authored-by: Tom Ludwig <[email protected]>
@thecoolwinter thecoolwinter added the enhancement New feature or request label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants