-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git branches list order and truncate priority issue #1647
Merged
austincondiff
merged 3 commits into
CodeEditApp:main
from
phlpsong:git-repo-list-optimize
Mar 25, 2024
Merged
Git branches list order and truncate priority issue #1647
austincondiff
merged 3 commits into
CodeEditApp:main
from
phlpsong:git-repo-list-optimize
Mar 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austincondiff
requested review from
austincondiff,
matthijseikelenboom,
FastestMolasses,
thecoolwinter and
tom-ludwig
March 24, 2024 04:47
austincondiff
previously approved these changes
Mar 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I love your momentum, keep up the good work! 🔥
tom-ludwig
requested changes
Mar 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're on 🔥!
Thanks for your hard work.
Co-authored-by: Tom Ludwig <[email protected]>
tom-ludwig
approved these changes
Mar 25, 2024
austincondiff
approved these changes
Mar 25, 2024
FastestMolasses
pushed a commit
to Angelk90/CodeEdit
that referenced
this pull request
Apr 11, 2024
* fix: branches list order issue and truncate priority of name * Update SourceControlManager.swift Co-authored-by: Tom Ludwig <[email protected]> * fix: optimize branch picker list issue and use lowercase to sort --------- Co-authored-by: Tom Ludwig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Mentioned in #1644 (comment)
As mentioned in #1644 (comment), I have decided not to include the fix for updating the icon color using list selection. The transition appeared less smooth, as evident in the screen recording.
Checklist
Screenshots
Screen.Recording.2024-03-24.at.10.32.02.mov