Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted titlebar spacing to be more accurate #1638

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Adjusted titlebar spacing to be more accurate #1638

merged 1 commit into from
Mar 18, 2024

Conversation

austincondiff
Copy link
Collaborator

@austincondiff austincondiff commented Mar 18, 2024 •
edited
Loading

Description

Made a few small spacing adjustments to be more consistent with Xcode. Changes include:

  • More space below branch picker
  • Symbol is a little smaller
  • More space between symbol and title

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

image

Top: Xcode
Middle: CodeEdit (before)
Bottom: CodeEdit (after)

@austincondiff austincondiff merged commit c395991 into CodeEditApp:main Mar 18, 2024
2 checks passed
FastestMolasses pushed a commit to Angelk90/CodeEdit that referenced this pull request Apr 11, 2024
@austincondiff @FastestMolasses
Adjusted titlebar spacing to be more accurate (CodeEditApp#1638)
d1911ac
@thecoolwinter thecoolwinter added the bug Something isn't working label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-ludwig tom-ludwig tom-ludwig approved these changes

@thecoolwinter thecoolwinter thecoolwinter approved these changes

@FastestMolasses FastestMolasses Awaiting requested review from FastestMolasses

@Wouter01 Wouter01 Awaiting requested review from Wouter01

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@austincondiff @thecoolwinter @tom-ludwig