Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Git branch picker does not load list in branch picker initially #1637

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

phlpsong
Copy link
Contributor

@phlpsong phlpsong commented Mar 18, 2024

Description

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

git-branch-picker-fix.mov

@austincondiff
Copy link
Collaborator

FYI, your screen capture does not show the menu because it is for the CodeEdit window and not the screen.

@phlpsong
Copy link
Contributor Author

FYI, your screen capture does not show the menu because it is for the CodeEdit window and not the screen.

Yes, the recorder tool has an issue with the Picker window recording, just upload a new one.

Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@tom-ludwig tom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!
@austincondiff the more I look at the Branch Picker, the less I like it. It just doesn't have the same polished look as Xcode's version. Maybe a bit to minimalistic. A discussion for another day, guess it's fine for now.

@austincondiff austincondiff merged commit 1f099d9 into CodeEditApp:main Mar 18, 2024
2 checks passed
@austincondiff austincondiff changed the title Git branch picker not load branch list and switch branch issue Fix: Git branch picker not load branch list and switch branch Mar 18, 2024
@austincondiff austincondiff changed the title Fix: Git branch picker not load branch list and switch branch Fix: Git branch picker does not load list in branch picker initially Mar 18, 2024
@austincondiff austincondiff added the bug Something isn't working label Mar 18, 2024
@phlpsong phlpsong deleted the git-branch-picker branch March 19, 2024 01:39
FastestMolasses pushed a commit to Angelk90/CodeEdit that referenced this pull request Apr 11, 2024
…ditApp#1637)

* fix: branch picker refresh issue and switch branch issue

* fix: source control history view not refresh after switch branch
Copy link

@Invisibleman9 Invisibleman9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants