Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Editor Layout Setup #1588

Merged

Conversation

thecoolwinter
Copy link
Collaborator

Description

Fixes the editor not correctly restoring state between window opens. The issue was twofold:

  • There was a bug with CEWorkspaceFileManager where paths that were being queried with spaces and URL encoded would be doubly url encoded (eg, path/test%20docs would resolve to path/test%2520docs) and not be able to be resolved.
  • The saved active editor was not being used correctly. This was fixed by adding a find method to the editor layouts to correctly use the "fixed" version of the layout after it's been resolved by the file manager.

The state restoration code also got some extra logging in case of errors and a couple extra checks.

Related Issues

  • N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2024-02-06.at.1.08.29.AM.mov

Copy link
Member

@EstebanBorai EstebanBorai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thecoolwinter thecoolwinter merged commit 80c5535 into CodeEditApp:main Feb 8, 2024
2 checks passed
@thecoolwinter thecoolwinter added the bug Something isn't working label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants