Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: git branches dropdown #1570

Merged
merged 2 commits into from
Jan 22, 2024
Merged

fix: git branches dropdown #1570

merged 2 commits into from
Jan 22, 2024

Conversation

FezVrasta
Copy link
Contributor

@FezVrasta FezVrasta commented Jan 22, 2024 •
edited
Loading

Description

This addresses the Git branch selector bug described by #1568, the dropdown now uses the Menu component. This also allows for the menu to be navigated and by keyboard

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

image

@FezVrasta FezVrasta mentioned this pull request Jan 22, 2024
Merged
6 tasks
austincondiff
austincondiff approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

thecoolwinter
thecoolwinter approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change, in the future we should also nest folders like feat/ or chore/.

@thecoolwinter thecoolwinter merged commit b8c7c9d into CodeEditApp:main Jan 22, 2024
2 checks passed
@thecoolwinter
Copy link
Collaborator

@allcontributors please add @FezVrasta for code

@allcontributors allcontributors bot mentioned this pull request Jan 22, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@thecoolwinter

I've put up a pull request to add @FezVrasta! 🎉

@tom-ludwig tom-ludwig mentioned this pull request Feb 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecoolwinter thecoolwinter thecoolwinter approved these changes

@0xWDG 0xWDG 0xWDG approved these changes

@austincondiff austincondiff austincondiff approved these changes

@EstebanBorai EstebanBorai Awaiting requested review from EstebanBorai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FezVrasta @thecoolwinter @austincondiff @0xWDG