Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings): section with glob pattern crud #1507

Conversation

EstebanBorai
Copy link
Member

@EstebanBorai EstebanBorai commented Dec 10, 2023

Description

Introduces a Search section for Application Settings where the user is able to
add Glob Patterns for files that should be ignored in:

  • Project Find (Indexing)
  • Open Quickly

This PR adds UI primitives while enforcing ignored files will be implemented by @activcoding in a separate PR.

Refer to: #1507 (comment)

CleanShot.2024-01-30.at.23.01.14.mp4

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

@EstebanBorai EstebanBorai changed the title 1463 exclude files and folders from project find and open quickly feat: exclude files and folders from project find and open quickly Dec 10, 2023
@EstebanBorai EstebanBorai linked an issue Dec 10, 2023 that may be closed by this pull request
@EstebanBorai
Copy link
Member Author

@CodeEditApp/maintainers I'm still playing with View Model and persisting these settings so I have the following UI which I'm not sure its pretty user friendly.

Screenshot 2023-12-10 at 3 52 24 PM

Based on the issue screenshot:

image

I gave a shot to VSCode appraoach and looks quick and easy to use:

Screen.Recording.2023-12-10.at.3.54.59.PM.mov

Any suggestions?

@matthijseikelenboom
Copy link
Contributor

A pop-up might by a bit much. I think a table approach might be better? With editable rows

@EstebanBorai EstebanBorai force-pushed the 1463-exclude-files-and-folders-from-project-find-and-open-quickly branch from 86c9efa to 4706282 Compare December 20, 2023 01:08
@EstebanBorai
Copy link
Member Author

A pop-up might by a bit much. I think a table approach might be better? With editable rows

Totally! Thats tho current approach now! Thanks for the feedback!

@EstebanBorai EstebanBorai force-pushed the 1463-exclude-files-and-folders-from-project-find-and-open-quickly branch from 834ebc7 to ab129ee Compare January 13, 2024 14:34
@tom-ludwig
Copy link
Member

Hey @EstebanBorai, how's it going on your end? Is the UI all set? If so, I can lend a hand in integrating it with the indexer. By the way, I've got #1465 on my plate, so feel free to merge the UI, and I'll roll out another PR incorporating your improvements for the actual indexing.

@EstebanBorai
Copy link
Member Author

Hey @EstebanBorai, how's it going on your end? Is the UI all set? If so, I can lend a hand in integrating it with the indexer. By the way, I've got #1465 on my plate, so feel free to merge the UI, and I'll roll out another PR incorporating your improvements for the actual indexing.

Hey @activcoding! Yes please take a look, basically this implement the CRUD logic for Globs, its already loading from the settings file. Whats missing is the GlobPattern validation and actually make use of the GlobPatterns to ignore them

@tom-ludwig
Copy link
Member

@EstebanBorai thanks, I had a chat with Austin yesterday, and he's all good with merging this PR as long as the CRUD logic is solid in settings. Your changes will come into play in a future PR. I'll work on it as soon as I'm done with mine.

@EstebanBorai EstebanBorai force-pushed the 1463-exclude-files-and-folders-from-project-find-and-open-quickly branch from ab129ee to 4a7ac24 Compare January 31, 2024 01:58
@EstebanBorai EstebanBorai marked this pull request as ready for review January 31, 2024 02:04
@EstebanBorai EstebanBorai changed the title feat: exclude files and folders from project find and open quickly feat: search section with glob pattern crud Jan 31, 2024
austincondiff
austincondiff previously approved these changes Jan 31, 2024
Copy link
Member

@tom-ludwig tom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers, this is looking great. If you could make these minor tweaks, we'll be all set to merge.

@EstebanBorai EstebanBorai changed the title feat: search section with glob pattern crud feat(search): search section with glob pattern crud Feb 3, 2024
@EstebanBorai EstebanBorai changed the title feat(search): search section with glob pattern crud feat(settings): section with glob pattern crud Feb 3, 2024
Copy link
Member

@tom-ludwig tom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant! Thanks for your great work.

@tom-ludwig tom-ludwig merged commit acc3d4b into CodeEditApp:main Feb 3, 2024
2 checks passed
@EstebanBorai
Copy link
Member Author

Brilliant! Thanks for your great work.

Thanxs for you and @austincondiff for all the support guys!

@EstebanBorai EstebanBorai deleted the 1463-exclude-files-and-folders-from-project-find-and-open-quickly branch February 3, 2024 13:56
@EstebanBorai EstebanBorai linked an issue Mar 10, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants