Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: capability to open changed file in temp tab #1472

Merged
merged 2 commits into from
Nov 3, 2023
Merged

feat: capability to open changed file in temp tab #1472

merged 2 commits into from
Nov 3, 2023

Conversation

EstebanBorai
Copy link
Member

Description

Provides access to tho workspace to open a modified file from the Source Version Control
Panel.

Related Issues

N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • [-] The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2023-11-03.at.12.36.02.AM.mov

austincondiff
austincondiff previously approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Edit: Please fix that SwiftLint issue before merging.

0xWDG
0xWDG approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@0xWDG 0xWDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@austincondiff austincondiff merged commit 239b1cf into CodeEditApp:main Nov 3, 2023
2 checks passed
@thecoolwinter thecoolwinter added the enhancement New feature or request label Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xWDG 0xWDG 0xWDG approved these changes

@austincondiff austincondiff austincondiff approved these changes

@thecoolwinter thecoolwinter Awaiting requested review from thecoolwinter

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EstebanBorai @austincondiff @0xWDG @matthijseikelenboom @thecoolwinter