Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filter button overflow #1469

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Fix filter button overflow #1469

merged 1 commit into from
Oct 29, 2023

Conversation

rational-kunal
Copy link
Contributor

Description

  • Filter button/icon on Project Navigation Toolbar is overflowing on the left.
  • I fixed this by adding filter button some extra padding to the left (similar to the right padding added for Clear Filter button).

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code --> Simple change so no documentation needed

Screenshots

Before After

austincondiff
austincondiff approved these changes Oct 29, 2023
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@thecoolwinter thecoolwinter merged commit 8a64bc4 into CodeEditApp:main Oct 29, 2023
2 checks passed
@rational-kunal rational-kunal deleted the fix-filter-icon-overflow branch October 29, 2023 15:31
@thecoolwinter thecoolwinter added the bug Something isn't working label Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xWDG 0xWDG 0xWDG approved these changes

@austincondiff austincondiff austincondiff approved these changes

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

@thecoolwinter thecoolwinter Awaiting requested review from thecoolwinter

@Wouter01 Wouter01 Awaiting requested review from Wouter01

@KaiTheRedNinja KaiTheRedNinja Awaiting requested review from KaiTheRedNinja

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 Filter Icon overflowing on the left
4 participants
@rational-kunal @austincondiff @0xWDG @thecoolwinter