Red close button unsaved indicator #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austincondiff
requested review from
austincondiff,
0xWDG,
matthijseikelenboom,
lukepistrol,
bombardier200 and
thecoolwinter
0xWDG
approved these changes
Oct 19, 2023
This was referenced Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for window close unsaved indicator if any tabs have modified content.
See screencast below for example.
Not sure if this a good solution, it's listening for all files
isDocumentEditedand all tabs (if file modified and then tab closed before saving, we also need to recalculate if whole window is dirty)Related Issues
Checklist
Screenshots
Screen.Recording.2023-10-18.at.4.47.57.PM.mov