-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project navigator files watch fixes #1452
Project navigator files watch fixes #1452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! Fix the SwiftLint errors and you should be good to go! Check out the SwiftLint section of our Code Style page in our wiki for real-time warnings locally.
@austincondiff SwiftLint failed in unrelated to this PR file, also Xcode doesn't show warning there for me. |
It should show up if you have SwiftLint configured correctly but I could be wrong. We can go ahead if it is unrelated then. In the future, if the issue doesn't yet exist, feel free to create one and reference it in your PR so we can track it. |
@austincondiff I have 70+ warnings for |
Thanks 🙂 |
Description
I didn't find if there is a issue for this. But project navigator file watch was broken for me.
I decided to check if I can fix it. Works great for me now (see attached screen recording).
I updated
DirectoryEventStream
to listen for file changes instead of folders. This can be useful in other places for example when file modified, plus now it returns correct event type (previously it always returnedchangeInDirectory
for me).Fixed bug in files diff (
CEWorkspaceFileManager.rebuildFiles
): it somethings recreatedCEWorkspaceFile
for folders that already inflattenedFileItems
Checklist
Screenshots
Screen.Recording.2023-10-15.at.2.35.57.PM.mov