Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Welcome Window on macOS Sonoma #1446

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Fixes Welcome Window on macOS Sonoma #1446

merged 2 commits into from
Oct 13, 2023

Conversation

avinizhanov
Copy link
Contributor

Description

Currently app tries to open welcome window which is already in NSApp.windows.
Added focus on welcome window if it exists in NSApp.windows

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

@avinizhanov
Fix #1445
083676a 
Checks if welcome window already exists in NSApp and tries to focus on it
@austincondiff austincondiff self-requested a review October 13, 2023 04:54
austincondiff
austincondiff previously approved these changes Oct 13, 2023
View reviewed changes
@avinizhanov
Copy link
Contributor Author

I missed trailing spacing warnings, fixed them

austincondiff
austincondiff approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@austincondiff austincondiff merged commit 08f7f1a into CodeEditApp:main Oct 13, 2023
2 checks passed
@austincondiff
Copy link
Collaborator

@all-contributors add @avinizhanov for bug

@allcontributors allcontributors bot mentioned this pull request Oct 13, 2023
Merged
@allcontributors
Copy link
Contributor

@austincondiff

@avinizhanov already contributed before to bug

@allcontributors
Copy link
Contributor

@austincondiff

I've put up a pull request to add @avinizhanov! 🎉

@austincondiff
Copy link
Collaborator

@avinizhanov someone in our Discord server just left this message. You have any idea what this is about?

@thecoolwinter thecoolwinter added the bug Something isn't working label Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austincondiff austincondiff austincondiff approved these changes

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avinizhanov @austincondiff @matthijseikelenboom @thecoolwinter