Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganized Editor, Tab Bar, and Path Bar files and added show/hide Path Bar setting, show/hide Utilities Area #1420

Merged

Conversation

austincondiff
Copy link
Collaborator

@austincondiff austincondiff commented Sep 8, 2023

Description

Reorganized editor, tab bar, and path bar files to make a little more sense.
Added show/hide path bar setting and view menu item.
Removed secondary background from tab and path bar in favor of the background on the containing view. Vibrancy effect is now more visible behind tab and path bars.

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

image image image

Hide/Show Utility Area via View menu

Screen.Recording.2023-09-08.at.11.42.44.PM.mov

Hide/Show Utility Area via Commands overlay

Screen.Recording.2023-09-08.at.11.43.40.PM.mov

Hid/Show Editor Path Bar

Screen.Recording.2023-09-08.at.11.44.23.PM.mov

@austincondiff austincondiff marked this pull request as ready for review September 9, 2023 04:47
@KaiTheRedNinja
Copy link
Contributor

Implementation details: The command for hiding/showing the utility section is reassigned every time the window is focused. This is because the model is per-window, but the commands is global. This reassignment is a bandaid fix and does not address the underlying issue, namely that certain commands need to be scoped to the window it was created in.

@austincondiff
Copy link
Collaborator Author

Note: Each time we hide/show via the View menu, it does not update the Show/Hide label (for the Navigator, Inspector, and Utility Area). We will fix this in a future PR.

@austincondiff austincondiff changed the title Reorganized editor, tab bar, and path bar files and added show/hide path bar setting Reorganized editor, tab bar, and path bar files and added show/hide path bar setting, show/hide Utilities Area Sep 9, 2023
@austincondiff austincondiff changed the title Reorganized editor, tab bar, and path bar files and added show/hide path bar setting, show/hide Utilities Area Reorganized editor, tab bar, and path bar files and added show/hide Path Bar setting, show/hide Utilities Area Sep 9, 2023
@austincondiff austincondiff changed the title Reorganized editor, tab bar, and path bar files and added show/hide Path Bar setting, show/hide Utilities Area Reorganized Editor, Tab Bar, and Path Bar files and added show/hide Path Bar setting, show/hide Utilities Area Sep 9, 2023
@thecoolwinter thecoolwinter merged commit 00da8c9 into CodeEditApp:main Sep 12, 2023
2 checks passed
@thecoolwinter thecoolwinter added the enhancement New feature or request label Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants