Added shadows to tab bar when tabs overflow #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austincondiff
requested review from
matthijseikelenboom,
lukepistrol,
thecoolwinter and
Wouter01
austincondiff
changed the title
matthijseikelenboom
requested changes
Aug 22, 2023
6 tasks
matthijseikelenboom
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added shadows to the tab bar when the tabs overflow.
In the OffsetableScrollView, if using a .horizontal axes, it reported an incorrect value. A fix was made by making it more like this. I modified it to expose a value relative to the trailing edge.
Checklist
Screenshots
Screen_Recording_2023-08-22_at_9.33.50_AM.mov