-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve Shell Integration Setup Process (#1387) #1388
feat: Improve Shell Integration Setup Process (#1387) #1388
Conversation
Signed-off-by: Qian Qian "Cubik" <[email protected]>
Signed-off-by: Qian Qian "Cubik" <[email protected]>
Signed-off-by: Qian Qian "Cubik" <[email protected]>
P.S.: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this also removes the annoying 'source' command that gets added to the terminal history?
Yes |
@Cubik65536 can you fix swiftlint errors? |
Signed-off-by: Qian Qian "Cubik" <[email protected]>
d8720ed
I pushed a fix |
Signed-off-by: Qian Qian "Cubik" <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Description
In PR #1298 , some commands are executed automatically when creating a new terminal to let the terminal title change according to the program running. But these commands will be shown to the user during the setup process.
In this PR, I moved the shell integration setup commands into user's shell's source files (
~/.zshrc
,~/.profile
, etc.) and moved the shell integration check & install into a dedicated function directly in our App (instead of having an shell script), so no commands needs to be executed in user's terminal when it's created.This is briefly how it works:
This still works for both zsh (with or without ohmyzsh) and bash.
Related Issues
Checklist
Screenshots
2023-07-20.15-11-59.mp4