-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed close tab and close window shortcut #1381
Conversation
Looking back at this, the change I made by removing the shortcut from |
I would prefer that cmd+w just closes the tabs. if there are no active tabs open, i press cmd+q to close the app. others might disagree tho |
Description
The
command + w
shortcut closes the editor instead of the current file. The functionality to close the current file was already implemented inCodeEdit/Features/Tabs/Views/TabBarItemView.swift
. The fix was to remove this shortcut fromCodeEdit/Features/WindowCommands/FileCommands.swift
where it explicitly closes the editor. I moved this code to the correct keyboard shortcut (⌃⇧⌘W) which is the same as the one in Xcode.Related Issues
Closes #1370
Checklist