Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reveal file in the middle of Project Navigator #1352

Merged
merged 7 commits into from
Jun 23, 2023
Merged

Reveal file in the middle of Project Navigator #1352

merged 7 commits into from
Jun 23, 2023

Conversation

dscyrescotti
Copy link
Contributor

@dscyrescotti dscyrescotti commented Jun 22, 2023 •
edited
Loading

Description

This PR includes the reveal of the selected file in the middle like in VSCode and Xcode as follows.

  1. Bring the file to the middle of the outline view if the file that is outside of the visible frame of Project Navigator becomes active/selected. (Only if the auto reveal is turned on)
  2. Add the manual reveal action to the command ⌘⇧J to highlight and center the file which is not visible.

Related Issues

#1351

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2023-06-22.at.10.39.45.PM.mov

thecoolwinter
thecoolwinter requested changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny bug and one small change and I can merge this, see comment for how to fix. Looks awesome though!

.../Features/NavigatorSidebar/ProjectNavigator/OutlineView/ProjectNavigatorViewController.swift Outdated Show resolved Hide resolved
CodeEdit/Features/WindowCommands/NavigateCommands.swift Show resolved Hide resolved
@dscyrescotti
Merge remote-tracking branch 'origin/main' into feat/reveal-file
beaca6d 
# Conflicts:
#	CodeEdit/Features/WindowCommands/NavigateCommands.swift
@austincondiff
Copy link
Collaborator

Please fix SwiftLint errors.

thecoolwinter
thecoolwinter approved these changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

0xWDG
0xWDG approved these changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@0xWDG 0xWDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@bombardier200 bombardier200 merged commit 6d60081 into CodeEditApp:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecoolwinter thecoolwinter thecoolwinter approved these changes

@0xWDG 0xWDG 0xWDG approved these changes

@austincondiff austincondiff Awaiting requested review from austincondiff

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

@Wouter01 Wouter01 Awaiting requested review from Wouter01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dscyrescotti @austincondiff @0xWDG @thecoolwinter @bombardier200