Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename bundle identifier to app.codeedit.CodeEdit #1287

Merged
merged 4 commits into from
Jun 15, 2023

Conversation

Wouter01
Copy link
Member

Description

This PR renamed the bundle identifier (and other stuff) from austincondiff.CodeEdit to com.codeedit.CodeEdit.

This will reset all saved settings on a user's machine.

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

@bombardier200
Copy link
Contributor

Are you able to see if this effects Sparkle and the app updates?

@Wouter01
Copy link
Member Author

Are you able to see if this effects Sparkle and the app updates?

Thanks for pointing that out, I wouldn't be surprised if this breaks Sparkle. Are we able to test this?

0xWDG
0xWDG previously approved these changes May 30, 2023
@0xWDG
Copy link
Collaborator

0xWDG commented May 30, 2023

Are you able to see if this effects Sparkle and the app updates?

https://github.com/CodeEditApp/CodeEdit/tree/main/AppCast There is no mention of the bundle id, therefore I don't expect any problems.

@austincondiff
Copy link
Collaborator

austincondiff commented May 30, 2023

@0xWDG Unless it is encoded in one of the github action secrets that it uses.

@lukepistrol do you have any idea if this would break as a result of a bundle id change?

@0xWDG
Copy link
Collaborator

0xWDG commented May 30, 2023

@0xWDG Unless it is encoded in one of the github action secrets that it uses.

@lukepistrol do you have any idea if this would break as a result of a bundle id change?

https://github.com/CodeEditApp/CodeEdit/blob/main/.github/workflows/appcast.yml Also here i don't see any mention of the bundle identifier.

@bombardier200
Copy link
Contributor

sparkle-project/Sparkle#1600
I still haven't been able to test it but based on this it seems like it definitely will effect sparkle.

@davdroman
Copy link

davdroman commented Jun 14, 2023

Shouldn't it be app.codeedit.CodeEdit? Since codeedit.app is the official domain.

@austincondiff austincondiff changed the title rename bundle identifier to com.codeedit.CodeEdit rename bundle identifier to app.codeedit.CodeEdit Jun 15, 2023
OpenWithCodeEdit/FinderSync.swift Outdated Show resolved Hide resolved
OpenWithCodeEdit/FinderSync.swift Outdated Show resolved Hide resolved
OpenWithCodeEdit/FinderSync.swift Outdated Show resolved Hide resolved
OpenWithCodeEdit/OpenWithCodeEdit.entitlements Outdated Show resolved Hide resolved
Copy link
Contributor

@bombardier200 bombardier200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bombardier200 bombardier200 merged commit ae05b6a into CodeEditApp:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants