-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename bundle identifier to app.codeedit.CodeEdit #1287
rename bundle identifier to app.codeedit.CodeEdit #1287
Conversation
Signed-off-by: Wouter01 <[email protected]>
Are you able to see if this effects Sparkle and the app updates? |
Thanks for pointing that out, I wouldn't be surprised if this breaks Sparkle. Are we able to test this? |
https://github.com/CodeEditApp/CodeEdit/tree/main/AppCast There is no mention of the bundle id, therefore I don't expect any problems. |
@0xWDG Unless it is encoded in one of the github action secrets that it uses. @lukepistrol do you have any idea if this would break as a result of a bundle id change? |
https://github.com/CodeEditApp/CodeEdit/blob/main/.github/workflows/appcast.yml Also here i don't see any mention of the bundle identifier. |
sparkle-project/Sparkle#1600 |
Signed-off-by: Wouter01 <[email protected]>
Shouldn't it be |
CodeEdit/Features/QuickOpen/ViewModels/QuickOpenViewModel.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/Settings/Pages/GeneralSettings/GeneralSettingsView.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/Settings/Pages/GeneralSettings/GeneralSettingsView.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR renamed the bundle identifier (and other stuff) from austincondiff.CodeEdit to com.codeedit.CodeEdit.
This will reset all saved settings on a user's machine.
Checklist