Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Settings search results are capitalized #1546

Closed
luah5 opened this issue Jan 5, 2024 · 2 comments
Closed

🐞 Settings search results are capitalized #1546

luah5 opened this issue Jan 5, 2024 · 2 comments
Assignees
Labels
bug Something isn't working triage needed

Comments

@luah5
Copy link
Member

luah5 commented Jan 5, 2024

Description

When using the settings search the results are all capitalized

To Reproduce

  1. Open settings
  2. Search for a setting

See that it is capitalized even though the normal setting is not capitalized in the same way

Expected Behavior

The search results should not be capitalized

Version Information

CodeEdit: [0.0.3-alpha.37]
macOS: [14.1.2]
Xcode: [e.g. 14.2]

Additional Context

N/A

Screenshots

shot 2 shot 3
@luah5 luah5 added the bug Something isn't working label Jan 5, 2024
@RayZhao1998 RayZhao1998 self-assigned this Jan 6, 2024
RayZhao1998 added a commit to RayZhao1998/CodeEdit that referenced this issue Jan 6, 2024
thecoolwinter pushed a commit that referenced this issue Jan 9, 2024
* fix(#1540): fix default selection in settings

* fix(#1546): cancel capitalized for settings search results
@tom-ludwig
Copy link
Member

@RayZhao1998 Looks like the issue got sorted in #1547, but just want to double-check – did I miss anything?

@tom-ludwig
Copy link
Member

The problem has been addressed in pull request #1547, although it hasn't been officially marked as closed. Just a friendly reminder to include '* closed #0000' in pull requests that successfully resolve issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage needed
Projects
Status: 🏁 Complete
Development

No branches or pull requests

3 participants