Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mctp-bench: Add a utility tool to send/receive messages and display throughput #57

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

Timon-L
Copy link
Contributor

@Timon-L Timon-L commented Dec 19, 2024

A utility tool that implements a sender and receiver to benchmark mctp throughput. This is split into a sender command and a receive command in the same executable.

The receive command waits for incoming messages, notifies the user of first message received and then prints out measured throughput periodically.

Example usage:
mctp-bench recv

The sender command sends messages continously, the size of which can be set by the user, defaulting to 8 bytes.

Example usage:
mctp-bench send len 1000 eid 8

Copy link
Member

@mkj mkj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. Noted a few small things

src/mctp-bench.c Outdated Show resolved Hide resolved
src/mctp-bench.c Outdated Show resolved Hide resolved
src/mctp-bench.c Outdated Show resolved Hide resolved
src/mctp-bench.c Outdated Show resolved Hide resolved
src/mctp-bench.c Outdated Show resolved Hide resolved
src/mctp-bench.c Show resolved Hide resolved
…hroughput

A utility tool that implements a sender and receiver to benchmark mctp
throughput. This is split into a sender command and a receive command in the
same executable.

The receive command waits for incoming messages, notifies the user of first
message received and then prints out measured throughput periodically.

Example usage:
	mctp-bench recv

The sender command sends messages continously, the size of which can be
set by the user, defaulting to 8 bytes.

Example usage:
	mctp-bench send len 1000 eid 8

Signed-off-by: Timon Liu <[email protected]>
@Timon-L
Copy link
Contributor Author

Timon-L commented Dec 20, 2024

Thanks for the feedback, applied the suggested changes and added allocate tag function to check if SIOCMCTPALLOCTAG2 or SIOCMCTPALLOCTAG exists for the sender to use.

@jk-ozlabs jk-ozlabs merged commit 087634d into CodeConstruct:main Jan 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants