mctpd: Exit on control socket EOF

If we hit an EOF on the control socket, we'll keep getting cb_listen_control_message() invoked in a loop, as there will always be a POLLIN|POLLERR event pending. Instead, just exit here. Signed-off-by: Jeremy Kerr <[email protected]>
CodeConstruct · Jan 12, 2024 · ea5c9a3 · ea5c9a3
1 parent ee9b1af
commit ea5c9a3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/mctp.c b/src/mctp.c
@@ -1309,6 +1309,7 @@ int main(int argc, char **argv)
 	if (!cmd)
 		errx(EXIT_FAILURE, "no such command '%s'", cmdname);
 
+	mctp_ops_init();
 	ctx->nl = mctp_nl_new(ctx->verbose);
 	if (!ctx->nl)
 		errx(EXIT_FAILURE, "Error creating netlink object");

diff --git a/src/mctpd.c b/src/mctpd.c
@@ -720,6 +720,9 @@ static int cb_listen_control_msg(sd_event_source *s, int sd, uint32_t revents,
 	if (rc < 0)
 		goto out;
 
+	if (rc == 0)
+		errx(EXIT_FAILURE, "Control socket returned EOF");
+
 	if (addr.smctp_base.smctp_type != MCTP_CTRL_HDR_MSG_TYPE) {
 		warnx("BUG: Wrong message type for listen socket");
 		rc = -EINVAL;