Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation state #34

Merged
4 commits merged into from
Dec 13, 2024
Merged

Navigation state #34

4 commits merged into from
Dec 13, 2024

Conversation

sarross88
Copy link
Collaborator

Description

-1 - Same as Register User branch, but I added useNavigation from react-router-dom to add conditioning to my buttons, I also added Login functionality and toast package, make sure you run npm install!!! Formatting was done as well.

Copy link
Collaborator

@GinaCastromonte GinaCastromonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text-transform: uppercase; style on the input fields may cause the email or password to be submitted in all uppercase letters, which can result in login failures if the backend is case-sensitive.

Copy link
Collaborator

@GinaCastromonte GinaCastromonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Login and Register is working now. However, I noticed the 'login' button on the landing page goes to the register page.

I see this was fixed in a different PR

@devandres-tech devandres-tech closed this pull request by merging all changes into main in 6f1e5c6 Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants