Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farkhondeh dev1 #27

Merged
merged 18 commits into from
Dec 4, 2024
Merged

Farkhondeh dev1 #27

merged 18 commits into from
Dec 4, 2024

Conversation

F-sh2019
Copy link
Collaborator

@F-sh2019 F-sh2019 commented Dec 3, 2024

Description

1) What does this PR do? 2) List out what you did.
Alarm Component: Included Alarm page and alarm component

Related Issue

_Provide a link to the related issue

Type of Changes

Feature update/change/addition, bug fix, styling update, etc.

Acceptance Criteria

Include the checked-off acceptance criteria from the issue.

Update Screenshots

Provide screenshots of the view before and after the changes.

Before

After

Testing Instructions

In a list format, tell us how to test this PR.

Learnings (Optional)

Document any things you learned or 'gotchas' you experienced.

@F-sh2019 F-sh2019 closed this Dec 3, 2024
@F-sh2019 F-sh2019 reopened this Dec 3, 2024
@GinaCastromonte
Copy link
Collaborator

Screenshot 2024-12-04 at 2 15 57 PM There are still some formatting issues/ merge conflicts blocking this PR

@F-sh2019 F-sh2019 closed this Dec 4, 2024
@F-sh2019
Copy link
Collaborator Author

F-sh2019 commented Dec 4, 2024

updated prettier and pckage.json file

@F-sh2019
Copy link
Collaborator Author

F-sh2019 commented Dec 4, 2024

Updated prettier and package.json file

@F-sh2019 F-sh2019 reopened this Dec 4, 2024
Copy link
Collaborator

@ValeriGuerrero ValeriGuerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ValeriGuerrero ValeriGuerrero merged commit 252ae40 into main Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants