Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login and register pages #12

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Login and register pages #12

merged 6 commits into from
Nov 26, 2024

Conversation

sarross88
Copy link
Collaborator

Description

  1. Made component folder, added three files -index, Logo, and FormRow
  2. Altered the Landing page to have the Logo component
  3. Made the login page
  4. Made the register page
  5. all are assoicated with App2.jsx hooked into the main.jsx currently

Related Issue

Not sure why I am getting some red errors, my local computer has no issues with the code.

@GinaCastromonte
Copy link
Collaborator

@sarross88 Try to fix the formatting issues and push your code again

@sarross88
Copy link
Collaborator Author

What is specifically wrong with the formatting?

@GinaCastromonte
Copy link
Collaborator

Screenshot 2024-11-25 at 12 06 32 PM

@GinaCastromonte
Copy link
Collaborator

I tested this branch, and I think the code from the "setup pages and routes" branch is already included here. Please confirm. Additionally, there should only be one App.jsx file that is integrated together. It seems the design is primarily for mobile views; however, the landing page appeared distorted on my laptop. Lastly, I noted that the images folder needs to be placed in either the assets or the public folder.
Screenshot 2024-11-25 at 12 24 22 PM

@sarross88
Copy link
Collaborator Author

Fixed formatting and changed back main.jsx

@devandres-tech
Copy link
Collaborator

@sarross88 Not seeing formatting errors anymore. This is what I see when in mobile view:
Screenshot 2024-11-25 at 6 02 45 PM

Same as Gina, the image appears distorted when expanding to desktop. I think we should keep one App.jsx file to avoid confusion, it's ok if other people work on the same file, that's the point of version control. If something goes wrong we can always revert back to a working branch.

Not sure if you guys decided on using style components or just plain css (not sure if this was discussed on the last meeting which I couldn't attend). Let me know if you need some help fixing the styling for the css.

Desktop view:
Screenshot 2024-11-25 at 6 06 51 PM

cc @GinaCastromonte

@sarross88
Copy link
Collaborator Author

Just updated!

Copy link
Collaborator

@ValeriGuerrero ValeriGuerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ValeriGuerrero ValeriGuerrero merged commit 0fda49d into main Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants