-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Che 127/add remaining profile info to profile page #159
Merged
brok3turtl3
merged 17 commits into
CHE-113/story/Profiles-Improvements
from
CHE-127/Add-Remaining-Profile-Info-To-Profile-Page
Aug 8, 2024
Merged
Che 127/add remaining profile info to profile page #159
brok3turtl3
merged 17 commits into
CHE-113/story/Profiles-Improvements
from
CHE-127/Add-Remaining-Profile-Info-To-Profile-Page
Aug 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emaining-Profile-Info-To-Profile-Page Mergin updated story branch
Mnelson98
changed the base branch from
main
to
CHE-113/story/Profiles-Improvements
July 16, 2024 17:50
seantokuzo
requested changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brok3turtl3 we need a hulk smash dev into these branches
seantokuzo
reviewed
Jul 22, 2024
…emaining-Profile-Info-To-Profile-Page
brok3turtl3
merged commit Aug 8, 2024
0d4343e
into
CHE-113/story/Profiles-Improvements
1 check passed
brok3turtl3
deleted the
CHE-127/Add-Remaining-Profile-Info-To-Profile-Page
branch
August 8, 2024 19:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of CHE-113 story "profiles improvement", this PR adds the remaining profile information to the profile page.
Jira Task
CHE-127
Testing Instructions
NOTE: social media info (clickable icon) will only be displayed when a valid link is given. If not displayed, navigate to the edit profiles page and insert valid social media links for the profile being tested (see instructions below).
Instructions to add social media links
Checklist
npm run docker-test:all
in my local environment to check that this PR passes all unit tests.