Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Che 127/add remaining profile info to profile page #159

Conversation

Mnelson98
Copy link

@Mnelson98 Mnelson98 commented Jul 15, 2024

Description

As part of CHE-113 story "profiles improvement", this PR adds the remaining profile information to the profile page.

Jira Task

CHE-127

Testing Instructions

  1. Make sure all branches are up to date and you are working from feature branch
  2. Spin up the dev environment and log in
  3. Select "Profiles" from the nav bar
  4. Click on a profile and ensure all information is being displayed appropriately

NOTE: social media info (clickable icon) will only be displayed when a valid link is given. If not displayed, navigate to the edit profiles page and insert valid social media links for the profile being tested (see instructions below).

Instructions to add social media links

  1. Click on "account" then "edit profile" in the nav bar
  2. Scroll down to the various social media inputs
  3. Enter valid links for each site and click "save changes" when done
  4. Follow instructions above to navigate back to the profile page to verify that the social media icons are now present

Checklist

  • I added a descriptive title to this PR.
  • I filled out the Description, Jira Task, and Testing Instructions sections above.
  • I added or updated [Jest unit tests]for any changes to components, server-side controllers, etc.
  • I ran npm run docker-test:all in my local environment to check that this PR passes all unit tests.
  • I did a quick check to make sure my code changes follow the recommended style guide.

@Mnelson98 Mnelson98 changed the base branch from main to CHE-113/story/Profiles-Improvements July 16, 2024 17:50
@Mnelson98 Mnelson98 self-assigned this Jul 16, 2024
Copy link
Contributor

@seantokuzo seantokuzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brok3turtl3 we need a hulk smash dev into these branches

@brok3turtl3 brok3turtl3 merged commit 0d4343e into CHE-113/story/Profiles-Improvements Aug 8, 2024
1 check passed
@brok3turtl3 brok3turtl3 deleted the CHE-127/Add-Remaining-Profile-Info-To-Profile-Page branch August 8, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants