-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHE-195 Create BE Test Setup #154
Conversation
…thub.com/Code-Hammers/code-hammers into CHE-195/subtask/Create-BE-Test-Setup
…to CHE-195/subtask/Create-BE-Test-Setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seantokuzo Set up looks good! 🎉
Left a comment regarding a couple possible file deletions. As well, we should consider setting up Postgres as well but we can do that in a subsequent ticket. There is enough mongo based testing to keep us busy for awhile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seantokuzo This file and userController can probably just be deleted at this point. The new ticket suite will encompass any testing that existed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as profile controller. Lets axe it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good rename.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
derp derp 🤣
Description
global.login
helper function that generates valid cookie - for testing protected routes.DS_Store
to.gitignore
because it showed up in my working directory - get outta here with that ish MacJira Task
JIRA BILLET
Testing Instructions
npm run docker-test:solo Authenticated
C
for client when promptedAuthenticatedApp.test.tsx
runs and passesserver/controllers/
directory namedderp.test.ts
and copy the following code into it:it('gets a valid cookie with global login helper', async () => { const cookie = await login(); console.log(cookie); expect(cookie[0].split('=')[0]).toEqual('token'); });
npm run docker-test:solo derp
S
for server when promptedderp.test.ts
runs and passes and logs the cookie valueChecklist
All Team Members
npm run docker-test
in my local environment to check that this PR passes all unit tests.