-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHE-120] Add Total Posts Display On Threads #149
Merged
brok3turtl3
merged 18 commits into
CHE-110/story/Forums-Improvements
from
CHE-120/subtask/Add-Total-Posts-Display-On-Threads
Jun 19, 2024
Merged
[CHE-120] Add Total Posts Display On Threads #149
brok3turtl3
merged 18 commits into
CHE-110/story/Forums-Improvements
from
CHE-120/subtask/Add-Total-Posts-Display-On-Threads
Jun 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to be committed: modified: client/src/components/Forums/ThreadDetails/ThreadDetails.tsx
…te operation to align with design
…moved mongoose Aggregate type
…moved mongoose Aggregate type, fixed typos
…moved mongoose Aggregate type, removed console logs
brok3turtl3
changed the title
CHE-120/subtask/add total posts display on threads
[CHE-120] Add Total Posts Display On Threads
Jun 17, 2024
…Id as conditional
…ssthrough into aggregateSort
…/Add-Total-Posts-Display-On-Threads
seantokuzo
reviewed
Jun 18, 2024
seantokuzo
reviewed
Jun 18, 2024
seantokuzo
reviewed
Jun 18, 2024
JimmyTran48
approved these changes
Jun 18, 2024
seantokuzo
reviewed
Jun 18, 2024
seantokuzo
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments but this all is working great! Nice work Howard!
brok3turtl3
merged commit Jun 19, 2024
694166d
into
CHE-110/story/Forums-Improvements
1 check passed
brok3turtl3
deleted the
CHE-120/subtask/Add-Total-Posts-Display-On-Threads
branch
June 19, 2024 09:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to:
Extra:
server/controllers/helpers/queryHelpers.ts
to handle MongoDb aggregate for sortingJira Task
CHE-120
Testing Instructions
Checklist
All Team Members
npm run docker-test
in my local environment to check that this PR passes all unit tests.Additional Notes, Images, etc.
(This is space for any additional information or attachments you'd like to add as part of this PR.)