Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHE-120] Add Total Posts Display On Threads #149

Conversation

howardsun-dev
Copy link

@howardsun-dev howardsun-dev commented Jun 17, 2024

Description

This PR aims to:

  • add total post count on individual threads
  • add total reply count per thread on threadDisplay for All
  • add total reply count per thread on threadDisplay custom forums

Extra:

  • add to queryHelper in server/controllers/helpers/queryHelpers.ts to handle MongoDb aggregate for sorting
  • add type to forums for postCount

Jira Task

CHE-120

Testing Instructions

  • Ensure branches are up to date.
  • Navigate to Forums and click through All Forums and each Forum (ex: General) to see if reply count appears on the screen for each individual thread.
  • Click into the individual threads, and there should be a total post count for that thread (including the OP)

Checklist

All Team Members

  • I added a descriptive title to this PR.
  • I filled out the Description, Jira Task, and Testing Instructions sections above.
  • I added or updated [Jest unit tests]for any changes to components, server-side controllers, etc.
  • I ran npm run docker-test in my local environment to check that this PR passes all unit tests.
  • I did a quick check to make sure my code changes follow the recomended style guide.

Additional Notes, Images, etc.

(This is space for any additional information or attachments you'd like to add as part of this PR.)

@brok3turtl3 brok3turtl3 changed the title CHE-120/subtask/add total posts display on threads [CHE-120] Add Total Posts Display On Threads Jun 17, 2024
@brok3turtl3 brok3turtl3 added the enhancement New feature or request label Jun 17, 2024
Copy link
Contributor

@seantokuzo seantokuzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments but this all is working great! Nice work Howard!

@brok3turtl3 brok3turtl3 merged commit 694166d into CHE-110/story/Forums-Improvements Jun 19, 2024
1 check passed
@brok3turtl3 brok3turtl3 deleted the CHE-120/subtask/Add-Total-Posts-Display-On-Threads branch June 19, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants