-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHE-172] Refactor Server Startup and DB Connection #142
[CHE-172] Refactor Server Startup and DB Connection #142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great re-org here @seantokuzo ! 👍 It was overdue!
I think the front and back testing files need to be reviewed at this point and a fresh slate of refactoring and new testing tickets put up. Let's chat about that this week.
I left mostly attaboys but had a few questions around the compose files. ❓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Nice work @seantokuzo!
51888b5
into
CHE-167/story/BE-Refactor-Error-Handling
Description
As part of the CHE-167 story, this PR:
db.test.ts
andindex.test.ts
db.test.ts
Jira Task
JIRA TICKET
Testing Instructions
Checklist
All Team Members
npm run docker-build-check
in my local environment to check that this PR passes all linting checks and unit tests.