[CHE-192] Create Filters #139
Conversation
…rs for status and date
…92/story/Create-Filters
| @@ -159,8 +163,8 @@ const CreateApplicationPage = (): JSX.Element => { | |||
| className="w-full p-2 rounded bg-gray-800 text-white" | |||
| id="date_applied" | |||
| name="date_applied" | |||
| type="date" | |||
| value={formData.date_applied} | |||
| type="datetime-local" | |||
There was a problem hiding this comment.
including the time might be overkill
There was a problem hiding this comment.
Definitely. It is like this so that in the current environment I can test functionally without waiting days. I need the seconds for now.
There was a problem hiding this comment.
sounds good. should we prevent people from choosing a date/time in the future?
There was a problem hiding this comment.
Yes we should! New code inc.
There was a problem hiding this comment.
Left a few comments for review. I can't test this manually, getting an error from the postgres container no PostgreSQL user name specified in startup packet:
Also docker-compose-test.yml is still using the codehammers/ch-dev-dep-v2 image, so running tests locally throws an error that pg package is not installed
There was a problem hiding this comment.
LGTM - this works and builds in future tickets. Only thing I'd say is adding the postgres environment variables for the dev service too, save from having to add them to .env and change the image used in lint and test docker-compose yml's for local testing future tickets for this epic
…r postgres to dev container and code cleanup
…to CHE-192/story/Create-Filters
…hen creating an application
brok3turtl3
merged commit d5090c2
into
CHE-140/epic/Create-Job-Application-Tracker
Description
This PR adds two basic filters to the main application display page.
Jira Task
CHE-192
Testing Instructions
npm run docker-remove-allnpm run docker-devnpm run docker-remove-allChecklist
All Team Members
npm run docker-testin my local environment to check that this PR passes all unit tests.Additional Notes, Images, etc.