Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHE-188] Update Docker Remove All Script #132

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

brok3turtl3
Copy link
Contributor

@brok3turtl3 brok3turtl3 commented Jun 5, 2024

Description

This PR updates the docker-remove-all script to properly remove all images and volumes. It has also been updated to reflect recent changes in image naming conventions and react dynamically to future changes. The npm script has also been adjusted.

Jira Task

CHE-188

Testing Instructions

  1. Spin up some containers using npm run docker-dev and npm run docker-test:all
  2. execute the removal script using npm run docker-remove-all
  3. Verify that all containers, images, and volumes related to Code Hammers have been removed (except the mongo image)

Checklist

All Team Members

  • I added a descriptive title to this PR.
  • I filled out the Description, Jira Task, and Testing Instructions sections above.
  • I added or updated [Jest unit tests]for any changes to components, server-side controllers, etc.
  • I ran npm run docker-test in my local environment to check that this PR passes all unit tests.
  • I did a quick check to make sure my code changes follow the recommended style guide.

Additional Notes, Images, etc.

N/A

…image and also reflect changes in naming conventions and image structures
@brok3turtl3 brok3turtl3 added the enhancement New feature or request label Jun 5, 2024
@brok3turtl3 brok3turtl3 self-assigned this Jun 5, 2024
Copy link
Contributor

@seantokuzo seantokuzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great! Nice addition of the * for matching. Just one possible edge case to consider with volume removal but this lgtm

@brok3turtl3 brok3turtl3 requested a review from seantokuzo June 6, 2024 13:35
Copy link
Contributor

@seantokuzo seantokuzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brok3turtl3 brok3turtl3 merged commit 7910943 into dev Jun 6, 2024
1 check passed
@brok3turtl3 brok3turtl3 deleted the CHE-188/task/Update-Docker-Remove-All-Script branch June 6, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants