-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHE-169] Add Express Async Errors Dep #131
[CHE-169] Add Express Async Errors Dep #131
Conversation
…://github.com/Code-Hammers/code-hammers into CHE-169/subtask/Add-Express-Async-Errors-Dep
…://github.com/Code-Hammers/code-hammers into CHE-169/subtask/Add-Express-Async-Errors-Dep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seantokuzo I love this new approach to error handling. I think it will work really well as we continue to scale out and I am eager to see it put into use. Great work! 🎉
@seantokuzo I think you can go ahead and delete the PR for CHE-168 as all that code has been merged into this branch by the looks of it. |
…to CHE-169/subtask/Add-Express-Async-Errors-Dep
…thub.com/Code-Hammers/code-hammers into CHE-169/subtask/Add-Express-Async-Errors-Dep
08628cd
into
CHE-167/story/BE-Refactor-Error-Handling
Description
As part of the CHE-167 BE Refactor Error Handling story, this PR
This package wraps the entire express application so in the case of asynchronous methods (middlewares and controllers), instead of manually calling
next
passing in an error, we can just throw an error and it will automatically be caught and passed to thenext
function, invoking the global error handler.express-async-errors npm package
Because of the added dependency, a Docker image rebuild will be required once story branch is merged into dev
Future testing on this story branch will require this updated image OR a local image build
Jira Task
JIRA TICKET
Testing Instructions
N/A - testing unavailable until future tickets making use of this new functionality
Checklist
All Team Members
npm run docker-test
in my local environment to check that this PR passes all unit tests.