Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHE-166] PR Template Bug Fix 2 #126

Merged
merged 2 commits into from
Jun 1, 2024
Merged

Conversation

seantokuzo
Copy link
Contributor

@seantokuzo seantokuzo commented Jun 1, 2024

Description

Part deux: Deleted the old PR template and renamed the new PR template

Jira Task

CHE-166/task/PR-Template-Bug-Fix-2

Testing Instructions

Testing is for nerds

...which I am, so pull this branch and make sure there is only 1 pull_request_template.md and no pull_request_template_new.md or PULL_REQUEST_TEMPLATE_OLD.md - also run git status and make sure the working directory is clean

Checklist

All Team Members

  • I added a descriptive title to this PR.
  • I filled out the Description, Jira Task, and Testing Instructions sections above.
  • I added or updated [Jest unit tests]for any changes to components, server-side controllers, etc.
  • I ran npm run docker-test in my local environment to check that this PR passes all unit tests.
  • I did a quick check to make sure my code changes follow the recomended style guide.

Additional Notes, Images, etc.

Don't make Elvis angry
EF8E79ED-FF8D-43DE-998F-8124F486D01A

@seantokuzo seantokuzo changed the title Delete old PR template and rename new PR template to proper filename [CHE 166] PR Template Bug Fix 2 Jun 1, 2024
@seantokuzo seantokuzo changed the title [CHE 166] PR Template Bug Fix 2 [CHE-166] PR Template Bug Fix 2 Jun 1, 2024
@brok3turtl3 brok3turtl3 added the enhancement New feature or request label Jun 1, 2024
@brok3turtl3 brok3turtl3 self-requested a review June 1, 2024 10:47
Copy link
Contributor

@brok3turtl3 brok3turtl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill miss it =(

@brok3turtl3
Copy link
Contributor

Hulk say SMASH

@brok3turtl3 brok3turtl3 merged commit adaa0ba into dev Jun 1, 2024
1 check passed
@brok3turtl3 brok3turtl3 deleted the CHE-166/task/PR-Template-Bug-Fix-2 branch June 1, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants