Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHE-147] Restyle Buttons For Consistency #124

Conversation

Mnelson98
Copy link

@Mnelson98 Mnelson98 commented May 24, 2024

Description

As part of CHE-113 story "profiles improvement", this PR restyles the buttons for the "edit profile" page and account button in the "header".

Jira Task

CHE-147

Testing Instructions

  1. Make sure all branches are up to date and you are working from feature branch
  2. Log in and spin of the dev environment
  3. Review and test all buttons

Checklist

All Team Members

  • I added a descriptive title to this PR.
  • I filled out the Description, Jira Task, and Testing Instructions sections above.
  • I added or updated [Jest unit tests]for any changes to components, server-side controllers, etc.
  • I ran npm run docker-test in my local environment to check that this PR passes all unit tests.
  • I did a quick check to make sure my code changes follow the recomended style guide.

Additional Notes, Images, etc.

N/A

@Mnelson98 Mnelson98 added the enhancement New feature or request label May 24, 2024
@Mnelson98 Mnelson98 self-assigned this May 24, 2024
client/src/pages/EditProfilePage/EditProfilePage.tsx Outdated Show resolved Hide resolved
client/src/components/Header/Header.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@brok3turtl3 brok3turtl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Mnelson98. Refactor looks good and the buttons look awesome!

@brok3turtl3 brok3turtl3 requested a review from JimmyTran48 May 24, 2024 18:56
Copy link
Contributor

@JimmyTran48 JimmyTran48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brok3turtl3 brok3turtl3 merged commit 1a9f11a into CHE-113/story/Profiles-Improvements May 24, 2024
1 check passed
@brok3turtl3 brok3turtl3 deleted the CHE-147/subtask/Restyle-Buttons-For-Consistency branch May 24, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants