Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHE-148] Update Edit Profile To Redirect To Profile On Save #122

Conversation

brok3turtl3
Copy link
Contributor

@brok3turtl3 brok3turtl3 commented May 22, 2024

Description

As part of the CHE-113 Profiles Improvements Story this PR completes updates the EditProfile page to redirect to the user's profile page upon successfully saving and updating their profile.

Jira Task

CHE-148

Testing Instructions

  1. Ensure branches are up to date and launch the app from this feature branch using npm run docker-dev
  2. Open the EditProfile page using the account button drop-down and edit some information on the profile
  3. Make sure that when information is saved the user is redirected as expected and profile info is updated

Checklist

All Team Members

  • I added a descriptive title to this PR.
  • I filled out the Description, Jira Task, and Testing Instructions sections above.
  • I added or updated [Jest unit tests]for any changes to components, server-side controllers, etc.
  • I ran npm run docker-test in my local environment to check that this PR passes all unit tests.
  • I did a quick check to make sure my code changes follow the recommended style guide.

Additional Notes, Images, etc.

N/A

@brok3turtl3 brok3turtl3 added the enhancement New feature or request label May 22, 2024
@brok3turtl3 brok3turtl3 self-assigned this May 22, 2024
@brok3turtl3 brok3turtl3 changed the title Che 148/subtask/update edit profile to redirect to profile on save [CHE-148] Update Edit Profile To Redirect To Profile On Save May 22, 2024
Copy link

@serenahromano serenahromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :)

@brok3turtl3 brok3turtl3 merged commit fd565ba into CHE-113/story/Profiles-Improvements May 24, 2024
1 check passed
@brok3turtl3 brok3turtl3 deleted the CHE-148/subtask/Update-EditProfile-To-Redirect-To-Profile-On-Save branch May 24, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants