-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt flat style badges #44
Comments
I don't think they have the Platform badges yet |
But right now we have that parsed automatically from the podspec (i.e. https://cocoapod-badges.herokuapp.com/p/RestKit/badge.png) |
@irrationalfab when I have some time I'll add some more CP badges natively to shields (platform, license) |
Ace! |
Great except for the fact that they are not flat |
@segiddins also now that you are at it, fixing the blue color would be ace! |
what do you want the blue color changed to? (I happen to like it) |
CocoaPods color is bold-red however it clashes with build failure badges... so I'm on the fence. @orta might have an opinion about this. |
I'll wait to submit my shields PR until @orta weighs in Colors Needed:
|
lets try: dev - |
Guys, is it your interest to move the badges to inside the Cocoapods organization? If so, let me know and I'll discontinue cocoapod-badges. |
Update: I have SVG badges with flat style and license badges working under the branch shield_badges. They're still using the current orange color. The service is temporarily hosted under the url https://betabadges.herokuapp.com |
OK, @fjcaetano so far, I don't feel a need to bring them in-house ( though if it is costing you we sure can do so. ) I don't think we should differentiate between dev & normal pods, I don't think that distinction is something I'd ever look for when looking at a badge, I'm usually just interested in license / platform / version ( will be very glad to add license to cocoapods search eventually. ) Do we know if it's possible to have black text? if so, I'd like to try: pod version: |
this is mainly because I think it fits in terms of the visual hierarchy of brightness, the important thing is version, then platform then license. |
@orta, I switched the badge provider service to shields.io, so the output is the same:
|
Honestly, I don't like those colors. As mentioned, I think the red may cause confusion with "build failure" CI badges. The platform color actually looks good, but only with the flat style. And the license badge could be a little darker, I think the default blue color looks better. Nevertheless, I will set the colors to whatever you guys see fit since I believe it makes sense to conform to the official Cocoapods color scheme. |
@orta Nicely done 👍. Maybe a docs badge too? 😄. We should make LICENSE link to the license file too. |
What are the colors? |
|
https://www.dropbox.com/s/hydp1k8dmss7oce/Screenshot%202014-05-21%2015.52.53.png ? |
Using Orta-sanctioned colors from CocoaPods/pod-template#44
Wait, I don't get it. These changes are in the shields.io project... |
Right, I just had a PR merged in there |
There is already an official project providing these badges at cocoapod-badges that is the one everyone uses, but you created a new one (inside shields.io) without notifying anyone. What should I do with the official one then? |
Oh I was under the impression that this is what Orta/Fabio wanted. My bad if I misunderstood. |
Well, I'm not against moving it into shields.io, but I don't think it was discussed. The problem would be migrating those already using cocoapod-badges |
Hrm, now that shields.io support cocoapods as a first party platform I think it makes sense to start migration over to it. Not to detract from For the migration I actually have a copy of every cocoapods's readme on CocoaDocs.org's server, it might not be too bad to send them a "you should migrate, you've got x months to switch" message. |
I'd be willing to write a proxy server for |
Here is a basic rack app that redirects to shields: # config.ru
require 'rack/rewrite'
app = Proc.new do |env|
[404, {"Content-Type" => "text/plain", "X-Cascade" => "pass"}, ["Not Found: #{env['REQUEST_PATH']}"]]
end
app = Rack::Rewrite.new(app) do
r301 '/', 'http://badges.github.io/cocoapod-badges/'
r301 %r{/(.)/(.+)/(?:.+/)?badge.(.+)}, 'http://img.shields.io/cocoapods/$1/$2.$3'
end
run app It's running at http://secure-bastion-3309.herokuapp.com/ (See i.e. http://secure-bastion-3309.herokuapp.com/p/RestKit/badge.png) |
For me any of the solutions would be fine, the important is to have a rocking flat style with the appropriate colours. One the one hand I like the idea keep using the service of @fjcaetano as an acknowledgement of an early contribution; on the other ones, shields.io is a point of reference where to look for badges and would not require any form of maintenance. |
Using Orta-sanctioned colors from CocoaPods/pod-template#44
I'm really tight this week. Let's see if we can gather during WWDC to proxy these things 😉 |
^ is a ruby proxying app that would do the job |
I'll do it in Django, the same as it was before. It will be quick. @segiddins, can you add a badge in shields.io with a user specified version in the URL, regardless of what's in the podspec? cocoapod-badges had this feature and I think it would be nice to port over to shields.io:
|
For that, you can just specify the URL straight by the version, since then the pod name doesn't matter. |
The problem is the color. The end user may not know what the color for the version badge is. If at some point we decide to change that badge color, the one's specified "by hand" will differ from the official ones. I asked you to do it because my knowledge of Ruby tends to |
If the badge color changes in shields, we can update it in the proxy -Samuel E. Giddins On May 26, 2014, at 2:26 PM, Flávio Caetano [email protected] wrote: The problem is the color. The end user may not know what the color for the version badge is. If at some point we decide to change that badge color, the one's specified "by hand" will differ from the official ones. I asked you to do it because my knowledge of Ruby tends to nil. — |
@fjcaetano I don't see you at http://www.meetup.com/CocoaPods-SF/events/177557362/ Regardless we should meet up. |
@orta, I was to RSVP to the events but I'm having two absolutely heavy weeks (travel planning) and I completely forgot. |
get on the guest list and I'll push you to confirmed, we can't have someone whose helped out like you have not there. |
I'm on the whishlist. |
Gentlemen, after long overdue I finally proxied everything to shields.io service and discontinued the cocoapod-badges project. The URL service remains as legacy and every pod that has my badges in their README must already have been updated. Thank you all for your support, if there's anything else I can do, please, let me know. |
Guys, for the pod version img shield, how can I change the colour of it? I understand there may be conventions in place for the colour blue to be chosen but I don't think that the majority would care if I decided to make it a bright green so it matches with my other badges. |
See http://shields.io
They rock!
The text was updated successfully, but these errors were encountered: