Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dollar signs in unquoted strings #58

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Allow dollar signs in unquoted strings #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/nanaimo/writer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def write_object(object)
output
end

QUOTED_STRING_REGEXP = %r{\A\z|[^\w\./]|\A___}
QUOTED_STRING_REGEXP = %r{\A\z|[^\w\.\$/]|\A___}
private_constant :QUOTED_STRING_REGEXP

def write_string_quoted_if_necessary(object)
Expand Down
8 changes: 8 additions & 0 deletions spec/nanaimo/writer_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,14 @@ def to_s
expect(subject).to eq("#{utf8}Value /*A whimsical value*/\n")
end
end

describe 'string with dollar sign' do
let(:root_object) { %($ABC) }

it 'writes without quotes' do
expect(subject).to eq(%(#{utf8}$ABC\n))
end
end
end

describe QuotedString do
Expand Down