Skip to content
This repository has been archived by the owner on Nov 3, 2020. It is now read-only.

Polish README and fix installation instructions #419

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bih
Copy link

@bih bih commented Jan 9, 2020

Hello!

Excited to make my first pull request to this repo! I found a bug when trying to install the CocoaPods-app locally, the instructions were failing due to a missing rest dependency that is invoked in the Rakefile.

The fix for this is to execute gem install rest which I have added as a short-term fix. In another PR it might be better to do a catch in the Rakefile.

Other than that, I added the use of $ in the Terminal code snippets. Just a stylistic change more than anything.

Fix bug with installation - gem install rest
> Having an issue with running `rake app:rerequisities --quiet`? You might need to fork the CocoaPods/Specs repository locally to your computer. To do this simply run the following command:
>
> ```sh
> $ git clone [email protected]:CocoaPods/Specs.git ~/.cocoapods/repos/master --depth=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't encourage people to make shallow clones of the specs repo

$ rake release:build # Perform a full build of the bundle and app
$ rake release:cleanbuild # Create a clean build
$ rake release:sparkle # Version bump the Sparkle XML
$ rake release:upload # Upload release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the $ means you can't triple click a line to copy & paste for the CLI with little up-side: IMO not worth it. Thanks for thinking about how to improve it though!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants