This repository has been archived by the owner on Nov 3, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 283
[Rakefile] Update to Ruby 2.5 #155
Open
segiddins
wants to merge
1
commit into
master
Choose a base branch
from
seg-ruby-2.3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fails for me locally as well: https://github.com/rubygems/rubygems/blob/e4d5e4decc8823b6aaa704724399d96eb86ffc14/lib/rubygems/security.rb#L343 A quick check shows: p OpenSSL::Digest.constants #=> [:DigestError] Need to look into this at a later time. |
Fixed via rubygems/rubygems#1438 |
Ace. |
I'm good to merge this once we have a stable working release of a CP beta, let's juggle as few balls as we can till then. |
@orta we can't merge until there's a new RG release |
segiddins
force-pushed
the
seg-ruby-2.3
branch
from
November 7, 2016 18:34
58cdb14
to
01df4d0
Compare
This would be nice to get shipped next time we do an update |
@segiddins I'm gonna be shipping an update when I get back to Berlin, so will look into getting this in then 👍 |
@dantoml should I just close this? |
@segiddins Nope, I'll try and take a look at this this week |
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a newer Ruby & RubyGems