Remove default lifecycle rules. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herman-wong-cf
requested review from
kourosh-forti-hands and
frank-avila
as code owners
|
🌟 No Terraform files were modified in this PR or all modified Terraform files passed the Checkov checks. Good job! 🌟 |
matt-pappas-cf
approved these changes
Nov 22, 2024
frank-avila
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @matt-pappas-cf, having default lifecycle rules will likely cause issues.
Removed the default lifecycle rules. If no one specifies custom lifecycle rules, none will be created for them.
Updated README with an example of the parameters that should be passed when using custom lifecycle rules.