Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing handling of prefix and tags in lifecycle rules scoping #10

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

lsousadev
Copy link

@lsousadev lsousadev commented May 11, 2024

Fixes #9

Doesn't seem to affect any code downstream or upstream from the edited code.

Tested all the possibilities successfully:

  • 0 prefixes, 0 tags
  • 0 prefixes, 1 tag
  • 0 prefixes, 2+ tags
  • 1 prefix, 0 tags
  • 1 prefix, 1 tags
  • 1 prefix, 2+ tags
  • Note that you can't have more than 1 prefix per rule

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_lifecycle_configuration#example-usage

Copy link
Member

@kourosh-forti-hands kourosh-forti-hands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved added

@kourosh-forti-hands kourosh-forti-hands merged commit 3511320 into Coalfire-CF:main Aug 2, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lifecycle rule malformed xml when using only prefix and no tags for filter due to "and" block
2 participants