Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial test #1

Merged
merged 19 commits into from
Sep 26, 2023
Merged

Initial test #1

merged 19 commits into from
Sep 26, 2023

Conversation

kourosh-forti-hands
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/main.tf CKV_AWS_144 Ensure that S3 bucket has cross-region replication enabled aws_s3_bucket.s3_default FAILED
/main.tf CKV2_AWS_62 Ensure S3 buckets should have event notifications enabled aws_s3_bucket.s3_default FAILED

Please review the above report. ⚠️

@github-actions
Copy link
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/main.tf CKV_AWS_144 Ensure that S3 bucket has cross-region replication enabled aws_s3_bucket.s3_default FAILED
/main.tf CKV2_AWS_62 Ensure S3 buckets should have event notifications enabled aws_s3_bucket.s3_default FAILED

Please review the above report. ⚠️

@github-actions
Copy link
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/main.tf CKV_AWS_144 Ensure that S3 bucket has cross-region replication enabled aws_s3_bucket.s3_default FAILED
/main.tf CKV2_AWS_62 Ensure S3 buckets should have event notifications enabled aws_s3_bucket.s3_default FAILED

Please review the above report. ⚠️

@github-actions
Copy link
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/main.tf CKV2_AWS_62 Ensure S3 buckets should have event notifications enabled aws_s3_bucket.s3_default FAILED
/main.tf CKV_AWS_144 Ensure that S3 bucket has cross-region replication enabled aws_s3_bucket.s3_default FAILED

Please review the above report. ⚠️

@github-actions
Copy link
Contributor

Markdown Valid

@github-actions
Copy link
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/main.tf CKV2_AWS_62 Ensure S3 buckets should have event notifications enabled aws_s3_bucket.s3_default FAILED
/main.tf CKV_AWS_144 Ensure that S3 bucket has cross-region replication enabled aws_s3_bucket.s3_default FAILED

Please review the above report. ⚠️

@kourosh-forti-hands kourosh-forti-hands marked this pull request as ready for review September 12, 2023 18:04
@github-actions
Copy link
Contributor

Markdown Valid

@github-actions
Copy link
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/main.tf CKV2_AWS_62 Ensure S3 buckets should have event notifications enabled aws_s3_bucket.s3_default FAILED
/main.tf CKV_AWS_144 Ensure that S3 bucket has cross-region replication enabled aws_s3_bucket.s3_default FAILED

Please review the above report. ⚠️

@github-actions
Copy link
Contributor

Markdown Valid

@github-actions
Copy link
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/main.tf CKV2_AWS_62 Ensure S3 buckets should have event notifications enabled aws_s3_bucket.s3_default FAILED
/main.tf CKV_AWS_144 Ensure that S3 bucket has cross-region replication enabled aws_s3_bucket.s3_default FAILED

Please review the above report. ⚠️

@github-actions
Copy link
Contributor

Markdown Valid

@github-actions
Copy link
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/main.tf CKV2_AWS_62 Ensure S3 buckets should have event notifications enabled aws_s3_bucket.s3_default FAILED
/main.tf CKV_AWS_144 Ensure that S3 bucket has cross-region replication enabled aws_s3_bucket.s3_default FAILED

Please review the above report. ⚠️

@github-actions
Copy link
Contributor

Markdown Valid

@github-actions
Copy link
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/main.tf CKV2_AWS_62 Ensure S3 buckets should have event notifications enabled aws_s3_bucket.s3_default FAILED
/main.tf CKV_AWS_144 Ensure that S3 bucket has cross-region replication enabled aws_s3_bucket.s3_default FAILED

Please review the above report. ⚠️

@github-actions
Copy link
Contributor

Markdown Valid

@github-actions
Copy link
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/main.tf CKV2_AWS_62 Ensure S3 buckets should have event notifications enabled aws_s3_bucket.s3_default FAILED
/main.tf CKV_AWS_144 Ensure that S3 bucket has cross-region replication enabled aws_s3_bucket.s3_default FAILED

Please review the above report. ⚠️

douglas-f
douglas-f previously requested changes Sep 15, 2023
View reviewed changes
README.md Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Show resolved Hide resolved
variables.tf Show resolved Hide resolved
variables.tf Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
olegkharytonenko-cf
olegkharytonenko-cf reviewed Sep 20, 2023
View reviewed changes
README.md Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Markdown Valid

@github-actions
Copy link
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/main.tf CKV2_AWS_62 Ensure S3 buckets should have event notifications enabled aws_s3_bucket.s3_default FAILED
/main.tf CKV_AWS_144 Ensure that S3 bucket has cross-region replication enabled aws_s3_bucket.s3_default FAILED

Please review the above report. ⚠️

@olegkharytonenko-cf
Copy link
Contributor

LGTM

@olegkharytonenko-cf olegkharytonenko-cf merged commit ec11bb7 into main Sep 26, 2023
@olegkharytonenko-cf olegkharytonenko-cf deleted the initial-test branch September 26, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegkharytonenko-cf olegkharytonenko-cf olegkharytonenko-cf approved these changes

@douglas-f douglas-f douglas-f left review comments

@mscribellito mscribellito Awaiting requested review from mscribellito

@BClev BClev Awaiting requested review from BClev

@ksnavely-cf ksnavely-cf Awaiting requested review from ksnavely-cf

@cstano cstano Awaiting requested review from cstano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kourosh-forti-hands @olegkharytonenko-cf @douglas-f