Skip to content

Commit

Permalink
fix the instantiation of NoOpTracerProvider (open-telemetry#1577)
Browse files Browse the repository at this point in the history
  • Loading branch information
avzis authored Jan 12, 2023
1 parent bf9a8e8 commit 43d0c6c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def request_hook(span, conn, args, kwargs):

def test_no_op_tracer_provider(self):
RedisInstrumentor().uninstrument()
tracer_provider = trace.NoOpTracerProvider
tracer_provider = trace.NoOpTracerProvider()
RedisInstrumentor().instrument(tracer_provider=tracer_provider)

redis_client = redis.Redis()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ def test_no_op_tracer_provider(self):
engine = create_engine("sqlite:///:memory:")
SQLAlchemyInstrumentor().instrument(
engine=engine,
tracer_provider=trace.NoOpTracerProvider,
tracer_provider=trace.NoOpTracerProvider(),
)
cnx = engine.connect()
cnx.execute("SELECT 1 + 1;").fetchall()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ def response_hook(span, request_obj, response):

def test_no_op_tracer_provider(self):
URLLibInstrumentor().uninstrument()
tracer_provider = trace.NoOpTracerProvider
tracer_provider = trace.NoOpTracerProvider()
URLLibInstrumentor().instrument(tracer_provider=tracer_provider)

result = self.perform_request(self.URL)
Expand Down

0 comments on commit 43d0c6c

Please sign in to comment.