Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ISO 8601 duration specifications for pacemaker "time" properties #712

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Support ISO 8601 duration specifications for pacemaker "time" properties #712

merged 3 commits into from
Jul 21, 2023

Conversation

daaitudian
Copy link
Contributor

@daaitudian daaitudian commented Jul 10, 2023 •
edited
Loading

Hi @mirecheck,
I completed the adjustment based on your advice #598.
I submitted the second commit 37c4dcc to prevent the ISO8601 format time is used for stonith-watchdog-timeout.

@knet-jenkins
Copy link

knet-jenkins bot commented Jul 10, 2023

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/pcs/job/pcs-pipeline/job/PR-712/1/input

mirecheck
mirecheck requested changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@mirecheck mirecheck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @daaitudian,
thank you for your effort you are putting into this pull request. We really appreciate it.
There are few changes that has to be made before applying this PR. Please check the review comments and let me know if something is not clear.

pcs/lib/cluster_property.py Outdated Show resolved Hide resolved
pcs/lib/cluster_property.py Show resolved Hide resolved
pcs/lib/commands/cluster_property.py Outdated Show resolved Hide resolved
pcs/lib/validate.py Outdated Show resolved Hide resolved
pcs/lib/validate.py Outdated Show resolved Hide resolved
pcs_test/tier1/test_cluster_property.py Outdated Show resolved Hide resolved
pcs_test/tier0/lib/test_validate.py Outdated Show resolved Hide resolved
pcs_test/tier0/lib/test_validate.py Outdated Show resolved Hide resolved
pcs/lib/pacemaker/values.py Show resolved Hide resolved
pcs/lib/validate.py Show resolved Hide resolved
@mirecheck
Copy link
Collaborator

retest this please

@knet-jenkins
Copy link

knet-jenkins bot commented Jul 17, 2023

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/pcs/job/pcs-pipeline/job/PR-712/3/input

@knet-jenkins
Copy link

knet-jenkins bot commented Jul 17, 2023

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/pcs/job/pcs-pipeline/job/PR-712/4/input

@daaitudian
Copy link
Contributor Author

daaitudian commented Jul 17, 2023 •
edited
Loading

Hi @mirecheck,
Thanks a lot for your help, I completed the adjustment based on your advice.

@knet-jenkins
Copy link

knet-jenkins bot commented Jul 18, 2023

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/pcs/job/pcs-pipeline/job/PR-712/5/input

@knet-jenkins
Copy link

knet-jenkins bot commented Jul 20, 2023

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/pcs/job/pcs-pipeline/job/PR-712/6/input

@knet-jenkins
Copy link

knet-jenkins bot commented Jul 20, 2023

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/pcs/job/pcs-pipeline/job/PR-712/7/input

mirecheck
mirecheck reviewed Jul 20, 2023
View reviewed changes
pcs/lib/validate.py Outdated Show resolved Hide resolved
mirecheck
mirecheck reviewed Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@mirecheck mirecheck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @daaitudian,
Thanks for the update! I have fixed tests and issues reported by pylint, mypy and black. The pull request could be merged once it passes CI.

@tomjelinek tomjelinek merged commit d22b63f into ClusterLabs:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirecheck mirecheck mirecheck approved these changes

@ondrejmular ondrejmular Awaiting requested review from ondrejmular

@tomjelinek tomjelinek Awaiting requested review from tomjelinek tomjelinek is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daaitudian @mirecheck @tomjelinek